Update continuous data flagging #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added filter to exclude quality control samples from looking for cont. data
8 tasks
| @@ -265,6 +265,8 @@ TADA_FlagContinuousData <- function(.data, clean = FALSE, flaggedonly = FALSE, t | |||
|
|
|||
| if (length(noncont.data) >= 1) { | |||
| info_match <- noncont.data %>% | |||
| # remove quality control samples | |||
| dplyr::filter(!grepl("Quality Control", ActivityTypeCode)) %>% | |||
There was a problem hiding this comment.
There are a few ActivityTypeCode's that do not include "Quality Control" that are also QC samples. Could you reference the internal TADA package WQXActivityTypeRef here instead and keep only the results assigned by TADA as "Non_QC"?
There was a problem hiding this comment.
Yes - that is a better, more specific solution. I can make that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added filter to exclude quality control samples from continuous data search. I have not been able to recreate the issue with all NAs in continuous flag column by using examples from previous test failures or random data sets.